Skip to content

fix(lambda): allow retryAttempts = -1 for infinite retries in EventSourceMapping #34009

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Apr 3, 2025
Merged

fix(lambda): allow retryAttempts = -1 for infinite retries in EventSourceMapping #34009

merged 3 commits into from
Apr 3, 2025

Conversation

@pahud
Copy link
Contributor

@pahud pahud commented Apr 1, 2025 •
edited
Loading

Issue # (if applicable)

Fixes #34007

This PR addresses an inconsistency in the validation logic for the retryAttempts property of Lambda EventSourceMapping.

Previously, although the documentation indicated that -1 signifies infinite retries (and is the default), explicitly setting retryAttempts: -1 would cause a ValidationError because the validation logic enforced a lower bound of 0.

This change updates the validation in aws-cdk-lib/aws-lambda/lib/event-source-mapping.ts to correctly allow -1 as a valid value, aligning the implementation with the documented behavior.

Additionally, this PR includes:

  • Updates to the TSDoc for retryAttempts in aws-cdk-lib/aws-lambda-event-sources/lib/stream.ts to improve clarity regarding the valid range (-1 or 0 to 10000).
  • Updates to the unit tests in aws-cdk-lib/aws-lambda/test/event-source-mapping.test.ts to verify the corrected behavior.

Affected modules: aws-lambda, aws-lambda-event-sources

Reason for this change

Description of changes

Describe any new or updated permissions being added

Description of how you validated changes

Checklist

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license

@github-actions github-actions bot added bug This issue is a bug. effort/small Small work item – less than a day of effort labels Apr 1, 2025
@aws-cdk-automation aws-cdk-automation requested a review from a team April 1, 2025 23:48
@github-actions github-actions bot added the p2 label Apr 1, 2025
@mergify mergify bot added the contribution/core This is a PR that came from AWS. label Apr 1, 2025
aws-cdk-automation
aws-cdk-automation previously requested changes Apr 1, 2025
View reviewed changes
Copy link
Collaborator

@aws-cdk-automation aws-cdk-automation left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

(This review is outdated)

@codecov
Copy link

codecov bot commented Apr 1, 2025 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 83.98%. Comparing base (0923b5e) to head (a108680).
Report is 1 commits behind head on main.

Additional details and impacted files 
@@           Coverage Diff           @@
##             main   #34009   +/-   ##
=======================================
  Coverage   83.98%   83.98%           
=======================================
  Files         120      120           
  Lines        6976     6976           
  Branches     1178     1178           
=======================================
  Hits         5859     5859           
  Misses       1005     1005           
  Partials      112      112
Flag Coverage Δ
suite.unit 83.98% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Components Coverage Δ
packages/aws-cdk ∅ <ø> (∅)
packages/aws-cdk-lib/core 83.98% <ø> (ø)
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@godwingrs22 godwingrs22 added the pr-linter/exempt-integ-test The PR linter will not require integ test changes label Apr 2, 2025
@aws-cdk-automation aws-cdk-automation dismissed their stale review April 2, 2025 19:27

✅ Updated pull request passes all PRLinter validations. Dismissing previous PRLinter review.

@godwingrs22
Copy link
Member

godwingrs22 commented Apr 2, 2025

Hi @pahud, seems the build is failing because of the another unit test[aws-lambda-event-sources/lib/dynamodb.ts] that needs to be updated.

@mergify
Copy link
Contributor

mergify bot commented Apr 3, 2025

Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

@aws-cdk-automation
Copy link
Collaborator

aws-cdk-automation commented Apr 3, 2025

AWS CodeBuild CI Report

  • CodeBuild project: AutoBuildv2Project1C6BFA3F-wQm2hXv2jqQv
  • Commit ID: a108680
  • Result: SUCCEEDED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

@mergify
Copy link
Contributor

mergify bot commented Apr 3, 2025

Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

@mergify mergify bot merged commit 88e04f0 into aws:main Apr 3, 2025
20 checks passed
@github-actions
Copy link
Contributor

github-actions bot commented Apr 3, 2025

Comments on closed issues and PRs are hard for our team to see.
If you need help, please open a new issue that references this one.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Apr 3, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@aws-cdk-automation aws-cdk-automation aws-cdk-automation left review comments

+1 more reviewer

@godwingrs22 godwingrs22 godwingrs22 approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@godwingrs22 godwingrs22

Labels

bug This issue is a bug. contribution/core This is a PR that came from AWS. effort/small Small work item – less than a day of effort p2 pr-linter/exempt-integ-test The PR linter will not require integ test changes

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

aws-lambda-event-sources: Inconsistency in KinesisEventSource.retryAttempts validation

3 participants

@pahud @godwingrs22 @aws-cdk-automation